This repository has been archived by the owner on Feb 13, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to convert to Swift 4.2 syntax. This is a bit scary since there are no tests, but most of the changes are just renaming things, so should be ok. The only part where I had to refactor a bit more is the following:
processEditing
was usingNSTextStorageEditActions
for both platforms, like so:However, it seems that in 4.2 it was renamed to
NSTextStorage.EditActions
on iOS platform, but not on macOS. So I decided to refactor it like this:Hopefully this makes sense.