Skip to content

Commit

Permalink
Added Remove minimum interval value #1645
Browse files Browse the repository at this point in the history
#1645 has been added by changing the minimum value from 20 to 1. A
warning has been added that shows when the user enters a value less than
20 to state that performance issues may be enountered.

Signed-off-by: Matthew Nickson <mnickson@sidingsmedia.com>
  • Loading branch information
Computroniks committed Jun 8, 2022
1 parent 4992b16 commit 4227e75
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/languages/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export default {
checkEverySecond: "Check every {0} seconds",
retryCheckEverySecond: "Retry every {0} seconds",
retriesDescription: "Maximum retries before the service is marked as down and a notification is sent",
minimumIntervalWarning: "Warning: Intervals below 20 seconds may result in poor performance.",
ignoreTLSError: "Ignore TLS/SSL error for HTTPS websites",
upsideDownModeDescription: "Flip the status upside down. If the service is reachable, it is DOWN.",
maxRedirectDescription: "Maximum number of redirects to follow. Set to 0 to disable redirects.",
Expand Down
10 changes: 8 additions & 2 deletions src/pages/EditMonitor.vue
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,10 @@
<!-- Interval -->
<div class="my-3">
<label for="interval" class="form-label">{{ $t("Heartbeat Interval") }} ({{ $t("checkEverySecond", [ monitor.interval ]) }})</label>
<input id="interval" v-model="monitor.interval" type="number" class="form-control" required min="20" step="1">
<input id="interval" v-model="monitor.interval" type="number" class="form-control" required min="1" step="1">
<div class="form-text" v-if="monitor.interval < 20">
{{ $t("minimumIntervalWarning") }}
</div>
</div>

<div class="my-3">
Expand All @@ -176,7 +179,10 @@
{{ $t("Heartbeat Retry Interval") }}
<span>({{ $t("retryCheckEverySecond", [ monitor.retryInterval ]) }})</span>
</label>
<input id="retry-interval" v-model="monitor.retryInterval" type="number" class="form-control" required min="20" step="1">
<input id="retry-interval" v-model="monitor.retryInterval" type="number" class="form-control" required min="1" step="1">
<div class="form-text" v-if="monitor.retryInterval < 20">
{{ $t("minimumIntervalWarning") }}
</div>
</div>

<h2 v-if="monitor.type !== 'push'" class="mt-5 mb-2">{{ $t("Advanced") }}</h2>
Expand Down

0 comments on commit 4227e75

Please sign in to comment.