Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitors in Maintenance Mode incorrectly shown in Monitor count #2608

Closed
2 tasks done
Justinzobel opened this issue Jan 13, 2023 · 3 comments
Closed
2 tasks done

Monitors in Maintenance Mode incorrectly shown in Monitor count #2608

Justinzobel opened this issue Jan 13, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Justinzobel
Copy link

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

I have several monitors in maintenance as per the screenshot attached but they are showing in the Unknown count instead of Maintenance

image

👟 Reproduction steps

Unknown

👀 Expected behavior

Monitors shown in Maintenance count

😓 Actual Behavior

Monitors shown in Unknown count

🐻 Uptime-Kuma Version

1.19.4

💻 Operating System and Arch

Ubuntu 22.04.1 x86_64

🌐 Browser

Firefox

🐋 Docker Version

N/A

🟩 NodeJS Version

19.3.0

📝 Relevant log output

No response

@Justinzobel Justinzobel added the bug Something isn't working label Jan 13, 2023
@chakflying
Copy link
Collaborator

Cannot reproduce. What are the monitor types? Is there anything special about your setup?

@Justinzobel
Copy link
Author

Standard HTTPS monitors. Install is done as per the wiki non-docker instructions.

@chintan-golakiya
Copy link

chintan-golakiya commented Jan 15, 2023

I am able to reproduce.
when scheduled maintenance starts for monitor and monitor status changes from up or down to maintenance, value of unknown is increased instead of value of maintenance

cause : this.$root.monitorList[monitorID].maintenance is not updated when one of following status change happens for monitor
MAINTENANCE -> UP
MAINTENANCE -> DOWN
DOWN -> MAINTENANCE
UP -> MAINTENANCE

possible solution : emit getMonitorList from socket when one of the above status change happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants