Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable number of packets send for tests #2618

Closed
1 task done
moucho opened this issue Jan 16, 2023 · 6 comments
Closed
1 task done

Configurable number of packets send for tests #2618

moucho opened this issue Jan 16, 2023 · 6 comments
Labels
feature-request Request for new features to be added

Comments

@moucho
Copy link
Contributor

moucho commented Jan 16, 2023

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

Other

🔖 Feature description

After the change in #2223 , the number of packets sent changed from 10 to 1, which in some cases could lead to false alerts.

✔️ Solution

It could be interesting to have a setting for the number of packets sent for tests, the same as retries for example.

If not, I think it may be better to set it back to 10 as it was.

❓ Alternatives

No response

📝 Additional Context

No response

@moucho moucho added the feature-request Request for new features to be added label Jan 16, 2023
@Computroniks
Copy link
Contributor

Yeah, I am looking into this

@louislam
Copy link
Owner

louislam commented Jan 16, 2023

Duplicate of #1891

@louislam louislam marked this as a duplicate of #1891 Jan 16, 2023
@louislam
Copy link
Owner

Oh I messed up with the number of packets sent and packet size. Reopen.

@louislam
Copy link
Owner

OK, I messed up with deadline (-w) and timeout (-W)...

louislam added a commit that referenced this issue Jan 16, 2023
@louislam louislam marked this as not a duplicate of #1891 Jan 16, 2023
@chakflying
Copy link
Collaborator

@louislam looks like running the ping monitor on Windows triggers the error message "There is no deadline option on windows"
image

@louislam
Copy link
Owner

@louislam looks like running the ping monitor on Windows triggers the error message "There is no deadline option on windows" image

Yes, it should be fixed. See #2636.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

4 participants