-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort tags in dashboard list view #2785
Labels
feature-request
Request for new features to be added
Comments
made a quick PR |
PRs should be made against this repo, not your own, that way we can merge them here and see the changes easier |
Sorry- fat fingered mistake. Fixed |
@luckman212 given that the associated PR has been merged, can you close this issue or edit it to make clear what still needs to be done? |
Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🏷️ Feature Request Type
UI Feature
🔖 Feature description
It would be really nice if the tags were sorted so that monitors that have the same tag set would appear identical.
✔️ Solution
I quickly glanced at the code and it seemed like a simple
ORDER BY tag.name
would do herehttps://github.com/louislam/uptime-kuma/blob/fdc3b2d57a9037c4415d18fe01762e7960a7fd43/server/model/monitor.js#LL146C19-L146C19
I manually patched my 1.20.1 install and ... it worked!
So this could be a quick PR if accepted.
❓ Alternatives
No response
📝 Additional Context
No response
The text was updated successfully, but these errors were encountered: