-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in working with local proxy #4693
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
What do you mean concretely when you say "when working with local proxy"? |
As for me, I monitor a https URL which resolves to an IPv6 address and thus I use a "local" (as in: my own RFC1918 network) squid proxy which is reachable via IPv4. |
Not what I was fishing for: where does the error occur? |
On the dashboard log for the http(s) monitoring entry and in the container log as well:
Reverting to I would be willing to increase the log level, but I do not know how or if that helps. |
Using gluetun, I make myself a local proxy server. |
@CommanderStorm : You were right about line number 536 in 'server/model/monitor.js'. When I comment that out, everything works again. I just added a comment to your review... |
I think I understand how the error can occur, but strangely I can't reproduce this using a squid proxy connecting over HTTP. What is the protocol used connecting to the proxy when the error occurs? |
HTTP |
I use http to connect to the Squid proxy and the monitored URL is https. I think it is exactly this which causes the problem, as I wrote here: #4630 (comment) |
Okay, I'll implement the fix later today. |
🛡️ Security Policy
📝 Describe your problem
After updating to version 1.23.12, an error was found (Cannot set properties of undefined (setting 'valid') when working with local proxies
Rolling back to version 1.23.11 solved this problem.
I'm launching it in the docker.
📝 Error Message(s) or Log
No response
🐻 Uptime-Kuma Version
1.23.12
💻 Operating System and Arch
Debian (docker)
🌐 Browser
Chrome
🖥️ Deployment Environment
The text was updated successfully, but these errors were encountered: