Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in working with local proxy #4693

Closed
2 tasks done
Druidblack opened this issue Apr 19, 2024 · 14 comments · Fixed by #4700
Closed
2 tasks done

Error in working with local proxy #4693

Druidblack opened this issue Apr 19, 2024 · 14 comments · Fixed by #4700
Labels
area:core issues describing changes to the core of uptime kuma area:monitor Everything related to monitors bug Something isn't working

Comments

@Druidblack
Copy link

Druidblack commented Apr 19, 2024

⚠️ Please verify that this question has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

📝 Describe your problem

After updating to version 1.23.12, an error was found (Cannot set properties of undefined (setting 'valid') when working with local proxies
Rolling back to version 1.23.11 solved this problem.

I'm launching it in the docker.

📝 Error Message(s) or Log

No response

🐻 Uptime-Kuma Version

1.23.12

💻 Operating System and Arch

Debian (docker)

🌐 Browser

Chrome

🖥️ Deployment Environment

  • Runtime: Docker 26.0.1
  • Database:
  • Filesystem used to store the database on:
  • number of monitors:
@loveyu

This comment has been minimized.

@ThomasHineXYZ

This comment has been minimized.

@IceCodeNew

This comment has been minimized.

@meyergru

This comment has been minimized.

@CommanderStorm
Copy link
Collaborator

What do you mean concretely when you say "when working with local proxy"?

@meyergru
Copy link

As for me, I monitor a https URL which resolves to an IPv6 address and thus I use a "local" (as in: my own RFC1918 network) squid proxy which is reachable via IPv4.

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Apr 19, 2024

Not what I was fishing for: where does the error occur?

@meyergru
Copy link

meyergru commented Apr 19, 2024

On the dashboard log for the http(s) monitoring entry and in the container log as well:

2024-04-19T12:55:17+02:00 [MONITOR] WARN: Monitor #28 'Internet (IPv6)': Failing: Cannot set properties of undefined (setting 'valid') | Interval: 60 seconds | Type: http | Down Count: 0 | Resend Interval: 0
2024-04-19T12:55:19+02:00 [MONITOR] WARN: Monitor #32 'Internet': Failing: Child inaccessible | Interval: 60 seconds | Type: group | Down Count: 0 | Resend Interval: 0

Internet (IPv6) is the name of the monitoring item, Internet is the group it is in.

Reverting to 1.23.11 indeed fixes the problem.
Container log stays empty w/r to this with that version.

I would be willing to increase the log level, but I do not know how or if that helps.

@Druidblack
Copy link
Author

What do you mean concretely when you say "when working with local proxy"?

Using gluetun, I make myself a local proxy server.

@meyergru
Copy link

meyergru commented Apr 19, 2024

@CommanderStorm : You were right about line number 536 in 'server/model/monitor.js'. When I comment that out, everything works again. I just added a comment to your review...

@louislam louislam added bug Something isn't working and removed help labels Apr 20, 2024
@CommanderStorm CommanderStorm added the area:core issues describing changes to the core of uptime kuma label Apr 20, 2024
@CommanderStorm CommanderStorm added the area:monitor Everything related to monitors label Apr 20, 2024
@chakflying
Copy link
Collaborator

I think I understand how the error can occur, but strangely I can't reproduce this using a squid proxy connecting over HTTP. What is the protocol used connecting to the proxy when the error occurs?

@Druidblack
Copy link
Author

I think I understand how the error can occur, but strangely I can't reproduce this using a squid proxy connecting over HTTP. What is the protocol used connecting to the proxy when the error occurs?

HTTP

@meyergru
Copy link

I use http to connect to the Squid proxy and the monitored URL is https. I think it is exactly this which causes the problem, as I wrote here: #4630 (comment)

@chakflying
Copy link
Collaborator

Okay, I'll implement the fix later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core issues describing changes to the core of uptime kuma area:monitor Everything related to monitors bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants