Fix: Getting TLS certificate through proxy & prometheus update #4700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #4693
Fixes #4698
Also handles the issue in #3551 correctly
I think I found a way to listen for the
secureConnect
event, which eliminates the messy 2-step process of the previous fix. I also restored the old method of checking for thetlsSocket
after the response is received, since theproxy-agent
does not seem to work with thekeylog
event, but we can still obtain the TLS information through the socket.Feel free to test.
Type of change
Checklist
Screenshots (if any)