Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix for docker(-compose) to allow the app to be run as a regular user. #1286

Closed
wants to merge 9 commits into from
Closed

[BUGFIX] Fix for docker(-compose) to allow the app to be run as a regular user. #1286

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4e01e6a
Fix for docker(-compose) to allow the app to be run as a regular user.
justSem Feb 9, 2022
b6b5f2c
Updated entrypoint to properly asses and fix permissions.
justSem Feb 13, 2022
af613e0
Update extra/entrypoint.sh
justSem Apr 2, 2022
936b73d
Update extra/entrypoint.sh
justSem Apr 2, 2022
c8b4887
Update extra/entrypoint.sh
justSem Apr 2, 2022
524abb6
Update extra/entrypoint.sh
justSem Apr 2, 2022
3ef783e
Update extra/entrypoint.sh
justSem Apr 2, 2022
87f2860
Update extra/entrypoint.sh
justSem Apr 2, 2022
0c10fe9
Implemented suggested changes
justSem Apr 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 43 additions & 8 deletions extra/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,55 @@

# set -e Exit the script if an error happens
set -e
PUID=${PUID=0}
PGID=${PGID=0}
DATADIR=/app/data

files_ownership () {
# -h Changes the ownership of an encountered symbolic link and not that of the file or directory pointed to by the symbolic link.
# -R Recursively descends the specified directories
# -c Like verbose but report only when a change is made
chown -hRc "$PUID":"$PGID" /app/data
# Check if the $DATADIR folder is owned by the user invoking the container
if [ $(stat -c%u "$DATADIR") != $(id -u) ]; then
echo "File ownership incorrect, attempting to fix."
chown -hRc "$(id -u)":"$(id -g)" $DATADIR || echo "ERROR: Failed to set file ownership. Please run 'sudo chown -R $(id -u):$(id -g) /path/to/container/volume' to resolve."; exit 1
echo "File ownership fix succesful! Continuing."
fi

# Checks for R/W permissions
if [ $(stat -c%a "$DATADIR") -ne 770 ]; then
echo "Directory permissions incorrect, attempting to fix."
find $DATADIR -type d -exec chmod 770 {} \;

# Re-run the check
if [ $(stat -c%a "$DATADIR") -ne 770 ]; then
echo "ERROR: Failed to set file permissions. Please run 'sudo find /path/to/container/volume -type d chmod 770 {} \;' to resolve."
exit 1
fi
echo "Directory permission fix succesful! Continuing."
fi

# Check the R/W permissions on the files
if [ $(stat -c%a "$DATADIR"/* | head -n 1) != 640 ]; then
echo "File permissions incorrect. Attempting to fix."
find $DATADIR -type f -exec chmod 640 {} \;

# Re-run the check
if [ $(stat -c%a "$DATADIR"/* | head -n 1) != 640 ]; then
echo "ERROR: Failed to set file permissions. Please run 'sudo find /path/to/container/volume -type f chmod 640 {} \;' to resolve."
exit 1
fi
echo "File permission fix succesful! Continuing."
fi
}

echo "==> Performing startup jobs and maintenance tasks"
echo "==> Checking file permissions"
files_ownership

echo "==> Starting application with user $PUID group $PGID"
echo "==> Starting application as user: $(id -u) ($USER) and group $(id -g)"

# --clear-groups Clear supplementary groups.
exec setpriv --reuid "$PUID" --regid "$PGID" --clear-groups "$@"
if [ $(id -u) -eq 0 ];
then
# We're running as root, so we can use setpriv without problems.
exec setpriv --reuid "$PUID" --regid "$PGID" --clear-groups "$@"
else
# We're running as a regular user, so we'll launch the app as one.
exec "$@"
fi