Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ntfy push support #1674

Merged
merged 6 commits into from
Jun 6, 2022
Merged

feat: ntfy push support #1674

merged 6 commits into from
Jun 6, 2022

Conversation

philippdormann
Copy link
Contributor

@philippdormann philippdormann commented May 23, 2022 •
edited
Loading

Description

closes #1622

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Saibamen
Saibamen suggested changes May 23, 2022
View reviewed changes
Copy link
Contributor

@Saibamen Saibamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ESLint and fix errors

@philippdormann philippdormann marked this pull request as draft May 23, 2022 18:59
@philippdormann philippdormann marked this pull request as ready for review May 23, 2022 19:16
@philippdormann
Copy link
Contributor Author

Thanks for the heads-up, Adam 😆

Didn't mean to directly submit this PR as "ready for review" earlier today ^^

@louislam louislam added this to the 1.17.0 milestone May 24, 2022
@louislam louislam merged commit cc258dc into louislam:master Jun 6, 2022
@louislam
Copy link
Owner

louislam commented Jun 6, 2022

Love it, the easiest notification I have ever seen!

@philippdormann philippdormann deleted the feature/ntfy-support branch June 6, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saibamen Saibamen Saibamen requested changes

@Computroniks Computroniks Computroniks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Add Notification support for Ntfy
4 participants
@philippdormann @louislam @Saibamen @Computroniks