-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Tags Manager #1690
Feat: Tags Manager #1690
Conversation
It looks amazing |
I'm thinking maybe instead of editing it there, there is just a list of the tags, with an edit button and a delete button and the edit button opens up a modal where you can edit it and see a list of monitors in the list and remove them, change the color using any hex color, and Maybe it would be cool if you could add an icon as well? and then you can save it there. |
There seems to be a lack of high quality color picker library for Vue 3 that supports dark mode. The one from Vuetify looks nice, but I'm not sure if we should pull in something that big. We could maintain our own, but I'm not sure if it's worth the trouble. |
+1 |
c80820b
to
5ff30dd
Compare
What is the issue not to merge that ? |
What is the current status? When can we expect the function? |
5ff30dd
to
dfcae41
Compare
Improved design according to suggestions, the color dropdown will now detect the custom hex color and display accordingly. Screenshots are also updated. It's not a lot of functionality but I think it's complicated enough as it is, maybe with edge cases I did not think of.
|
a6f69db
to
ff9fc33
Compare
I also realized all the "Saved" messages from the server are not translated when they are displayed in the UI? Might want to add a way to handle this when displaying a toast. |
Yes, @karelkryda had opened a pr for server side translation. |
Fix: Remove unused color options Chore: Fix typo
ff9fc33
to
9c1ba97
Compare
We are getting there, thank you <3 |
Awesome! |
Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>
Thanks, work as expected. |
Description
Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)