Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Tags Manager #1690

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Feat: Tags Manager #1690

merged 3 commits into from
Jan 13, 2023

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented May 26, 2022

Description

  • View tags and monitors belonging to that tag
  • Edit tag name & color
  • Delete a tag (option to delete monitors with that tag?)

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

image

image

image

@louislam louislam linked an issue May 26, 2022 that may be closed by this pull request
2 tasks
@karelkryda
Copy link
Contributor

It looks amazing

@ashfn
Copy link

ashfn commented May 27, 2022

I'm thinking maybe instead of editing it there, there is just a list of the tags, with an edit button and a delete button and the edit button opens up a modal where you can edit it and see a list of monitors in the list and remove them, change the color using any hex color, and Maybe it would be cool if you could add an icon as well? and then you can save it there.

@chakflying
Copy link
Collaborator Author

There seems to be a lack of high quality color picker library for Vue 3 that supports dark mode. The one from Vuetify looks nice, but I'm not sure if we should pull in something that big. We could maintain our own, but I'm not sure if it's worth the trouble.

@Phyroks
Copy link

Phyroks commented Jun 30, 2022

+1

@bengivre
Copy link

What is the issue not to merge that ?

@ghost
Copy link

ghost commented Dec 19, 2022

What is the current status? When can we expect the function?

@chakflying
Copy link
Collaborator Author

chakflying commented Jan 3, 2023

Improved design according to suggestions, the color dropdown will now detect the custom hex color and display accordingly. Screenshots are also updated. It's not a lot of functionality but I think it's complicated enough as it is, maybe with edge cases I did not think of.

  • no custom color picker
  • no option to delete monitors with a tag
  • does not handle individual values set with each monitorTag

@chakflying
Copy link
Collaborator Author

I also realized all the "Saved" messages from the server are not translated when they are displayed in the UI? Might want to add a way to handle this when displaying a toast.

@chakflying chakflying marked this pull request as ready for review January 3, 2023 04:48
@louislam
Copy link
Owner

louislam commented Jan 3, 2023

I also realized all the "Saved" messages from the server are not translated when they are displayed in the UI? Might want to add a way to handle this when displaying a toast.

Yes, @karelkryda had opened a pr for server side translation.
#2232

@louislam louislam added this to the 1.20.0 milestone Jan 3, 2023
Fix: Remove unused color options

Chore: Fix typo
@bengivre
Copy link

We are getting there, thank you <3

@shynekomaid
Copy link
Contributor

Awesome!

src/components/TagEditDialog.vue Outdated Show resolved Hide resolved
Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>
@louislam louislam merged commit 468cb00 into louislam:master Jan 13, 2023
@louislam
Copy link
Owner

Thanks, work as expected.

@chakflying chakflying deleted the feat/tags-manager branch January 19, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] - How to manage TAGS ( delete / rename )
8 participants