Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove template comment in SECURITY.md #1754

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Remove template comment in SECURITY.md #1754

merged 1 commit into from
Jun 14, 2022

Conversation

SIMULATAN
Copy link
Contributor

Description

This PR removes a leftover comment from the security template in the SECURITY.md file

Type of change

  • Wiki/Docs-Update

Screenshots

screenshot of the leftover line

Computroniks
Computroniks approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@Computroniks Computroniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run lint passes. There seems to be an issue with the github actions and an external service returning 503 so it is failing. Nothing to to with your PR though.

@louislam
Copy link
Owner

npm run lint passes. There seems to be an issue with the github actions and an external service returning 503 so it is failing. Nothing to to with your PR though.

Yes, everyone suffer from the issue for more than 3 hours.
bahmutov/npm-install#80

It is also the reason why I don't put the whole deployment process or write any complicated steps on GitHub Actions. If GitHub Actions goes wrong, then you cannot run those steps in other environments. It is a good time to say GitHub Actions is a bad thing.

@SIMULATAN
Copy link
Contributor Author

According to the GitHub Statuspage, "GitHub Actions is experiencing degraded performance". Maybe this is related?

@Computroniks
Copy link
Contributor

According to the GitHub Statuspage, "GitHub Actions is experiencing degraded performance". Maybe this is related?

Yep. It is a cache issue that causes the 503 error

@louislam louislam merged commit dc23022 into louislam:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Computroniks Computroniks Computroniks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SIMULATAN @louislam @Computroniks