-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support redis monitor #2541
Conversation
Uptime Kuma crashed if the target is not a Redis server. Example:
|
I test postgres with same operation, which also crashed |
Thanks for testing, both may need to fix. But that is weird, because it should be inside try...catch. |
Sorry, my fault, if input error redis conn string, the server even can't startup, I will fix that |
Just have a quick look, I think the library is not actually a fully await/async library, you still need to add the event handler. Also there are 4 more possible events, better add them too for safety. |
fixed |
Remark for testing:
|
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #1376 for redis
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.