-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add badge for overall status of status-page #2574
Merged
louislam
merged 5 commits into
louislam:master
from
sjoukedv:feat/global-status-page-badge
Jul 8, 2023
Merged
feat(server): add badge for overall status of status-page #2574
louislam
merged 5 commits into
louislam:master
from
sjoukedv:feat/global-status-page-badge
Jul 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think you don't need to include the |
The logic is clear to me 🙏 |
My bad that lockfile slipped in there. |
I removed the lockfile and added |
@louislam can you review/merge this? |
…page-badge # Conflicts: # .gitignore
Thanks for the pr. Tested and it is working. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1616
Adds an API route
/api/status-page/:slug/badge
which shows the badge similar to the overall status on the status page itself.Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)
e.g.
/api/status-page/test/badge?label=<status-page>
returns the following:I wish badge-maker supported SVG as messages so that we can use the same font-awesome icon as the badge label