Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add "Add New Tag" button in settings #2764

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Closes #2745

Type of change

Please delete any options that are not relevant.

  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

@chakflying
Copy link
Collaborator Author

Just realized the dialog is missing logic for validating tags.

@chakflying chakflying marked this pull request as draft February 12, 2023 21:12
@chakflying chakflying marked this pull request as ready for review February 13, 2023 23:58
@ItsCryptic
Copy link

Can't wait for this to merge!

@louislam louislam added this to the 1.21.0 milestone Feb 15, 2023
@louislam louislam merged commit 98bb854 into louislam:master Feb 24, 2023
@chakflying chakflying deleted the feat/add-new-tag branch March 4, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to create tags directly in the tag manager
3 participants