Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Finnish language translation #2770

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Added Finnish language translation #2770

merged 2 commits into from
Feb 14, 2023

Conversation

JonneSaloranta
Copy link
Contributor

@JonneSaloranta JonneSaloranta commented Feb 13, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Added a language translations (Finnish)

Type of change

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@JonneSaloranta
Copy link
Contributor Author

Now with 100% Finnish translations.
picture

@louislam
Copy link
Owner

louislam commented Feb 14, 2023

Will be merged after #2767, thanks

@louislam
Copy link
Owner

Just realized that it had been merged previously, but it should be fi instead of fi-FI?

https://github.com/louislam/uptime-kuma/blob/master/src/lang/fi.json

@JonneSaloranta
Copy link
Contributor Author

Interesting... did not think to check the lang file. How come some other languages are using xx-XX format and some are not?

@louislam louislam merged commit aad087c into louislam:master Feb 14, 2023
@JonneSaloranta JonneSaloranta deleted the patch-1 branch February 14, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants