Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue with using IP Address as GRPC URL #2867

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

Small6oy
Copy link
Contributor

@Small6oy Small6oy commented Mar 1, 2023

Tick the checkbox if you understand [x]:

  • [ x] I have read and understand the pull request rules.

Description

I've been having an issue with trying to use an IP Address Host:Port combination in monitoring my GRPC instances.
Validation would fail

Fixes #(issue)
I changed the input type from url to text.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

I've been having an issue with trying to use an IPAddress Host:Port combination in monitoring my GRPC instances. 
This was because the input type was set to url instead of text.
Even if the pattern passes the match test, the url would block as it requires a fully qualified domain name with HTTP and this would fail to submit
@louislam louislam merged commit d4a31cf into louislam:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants