Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Core Bug Fix & Improvements #3003

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Maintenance Core Bug Fix & Improvements #3003

merged 4 commits into from
Mar 31, 2023

Conversation

louislam
Copy link
Owner

@louislam louislam commented Mar 30, 2023

Trying to fix the big issue of maintenance #2987, but realized that the schedule logic is over complicated and hard to fix, so I decided to change the core to use cron instead, which make the logic a lot easier.

  • Change to cron base. No long need to generate timeslots.
  • Improve isUnderMaintenance() without heavy queries.
  • Allow to use cron expression directly to set a schedule
  • Better Timezone handling especially for DST
  • No longer need to specify the date range in case you want to schedule it endlessly.

@louislam louislam merged commit 0f5a243 into master Mar 31, 2023
@louislam louislam deleted the maintenance-fix branch August 18, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant