Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gray out label for up/down/maintenance labels when they are zero #3037

Merged
merged 4 commits into from
May 19, 2024

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Apr 6, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Previously, the numbers in the Quick Stats panel were always displayed in color even if they were 0. This PR updates them to show up in gray unless they’re non-zero. This is particularly helpful for the “down” indicator since if you don’t see the red number you can be confident that none of your monitors are down.

Screenshot_2023-04-06 10 59 44

Type of change

Please delete any options that are not relevant.

  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
    (N/A)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Screenshot_2023-04-06 10 56 45

Screenshot_2023-04-06 10 57 16

Screenshot_2023-04-06 10 56 25

@chakflying chakflying mentioned this pull request Apr 14, 2023
1 task
src/pages/DashboardHome.vue Outdated Show resolved Hide resolved
src/pages/DashboardHome.vue Outdated Show resolved Hide resolved
src/pages/DashboardHome.vue Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm added the area:dashboard The main dashboard page where monitors' status are shown label Apr 3, 2024
@CommanderStorm
Copy link
Collaborator

Thanks for the bugfix!
Forgot to write a merge message and merge the PR the last time around.

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 668e8ba into louislam:master May 19, 2024
17 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants