Add HostedSMS.pl notification provider #3176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
requested changes
May 20, 2023
CommanderStorm
requested changes
May 20, 2023
CommanderStorm
requested changes
May 20, 2023
7 tasks
7 tasks
louislam
reviewed
Jun 29, 2023
|
|
||
| name = "hostedsms"; | ||
|
|
||
| async send(notification, msg, monitorJSON = null, heartbeatJSON = null) { |
There was a problem hiding this comment.
It seems that msg is never used.
When monitorJSON and heartbeantJSON are null, msg is used for other general messages such as testing or certificate alert.
CommanderStorm
requested changes
Aug 1, 2023
Comment on lines
+23
to
+28
| let textMsg = ""; | ||
| if (heartbeatJSON && heartbeatJSON.status === UP) { | ||
| textMsg = `✅ [${monitorJSON.name}] is back online`; | ||
| } else { | ||
| textMsg = `🔴 [${monitorJSON.name}] went down`; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let textMsg = ""; | |
| if (heartbeatJSON && heartbeatJSON.status === UP) { | |
| textMsg = `✅ [${monitorJSON.name}] is back online`; | |
| } else { | |
| textMsg = `🔴 [${monitorJSON.name}] went down`; | |
| } | |
| let textMsg = msg; | |
| if (heartbeatJSON && heartbeatJSON.status === UP) { | |
| textMsg = `✅ [${monitorJSON.name}] is back online`; | |
| } else if (heartbeatJSON && heartbeatJSON.status === DOWN) { | |
| textMsg = `🔴 [${monitorJSON.name}] went down`; | |
| } |
Comment on lines
+19
to
+22
| /* | ||
| Create shorter alert message to avoid extra SMS costs (1 SMS with unicode has limit to 70 characters) | ||
| https://github.com/louislam/uptime-kuma/pull/3176#discussion_r1199601497 | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /* | |
| Create shorter alert message to avoid extra SMS costs (1 SMS with unicode has limit to 70 characters) | |
| https://github.com/louislam/uptime-kuma/pull/3176#discussion_r1199601497 | |
| */ | |
| // Create shorter alert message to avoid extra SMS costs (1 SMS with unicode has limit to 70 characters) |
| @@ -0,0 +1,52 @@ | |||
| const NotificationProvider = require("./notification-provider"); | |||
| const axios = require("axios"); | |||
| const { UP } = require("../../src/util"); | |||
There was a problem hiding this comment.
Suggested change
| const { UP } = require("../../src/util"); | |
| const { UP, DOWN } = require("../../src/util"); |
Comment on lines
+10
to
+11
| let okMsg = "Sent Successfully."; | ||
|
|
There was a problem hiding this comment.
Suggested change
| let okMsg = "Sent Successfully."; | |
| const okMsg = "Sent Successfully."; | |
| const url = "https://api.hostedsms.pl/SimpleApi"; | |
| "Sender": notification.hostedsmsSenderName, | ||
| }; | ||
|
|
||
| let resp = await axios.post("https://api.hostedsms.pl/SimpleApi", data, config); |
There was a problem hiding this comment.
Suggested change
| let resp = await axios.post("https://api.hostedsms.pl/SimpleApi", data, config); | |
| let resp = await axios.post(url, data, config); |
| let okMsg = "Sent Successfully."; | ||
|
|
||
| try { | ||
| let config = { |
There was a problem hiding this comment.
Suggested change
| let config = { | |
| const config = { |
| textMsg = `🔴 [${monitorJSON.name}] went down`; | ||
| } | ||
|
|
||
| let data = { |
There was a problem hiding this comment.
Suggested change
| let data = { | |
| const data = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
This PR adds support HostedSMS.pl SMS gateway via HTTPS SimpleApi.
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)