-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Show elapsed time in HeartbeatBar #3219
Conversation
This is useful, I would love for this to be merged. |
This is a tough one, personally I think having the line connects the left and right element, making the design more cohesive. But maybe I'm biased. |
I added the option to choose the style. Also dimmed the line a little bit. A line is actually hard to be handled in modern browsers and monitors. For example, with 125% dpi, the browser will "enlarge" 1px to 1.25px, but eventually monitors can display integer pixel only, it will be rounded down to 1px, but sometimes I don't know why it's rounded up to 2px like the image below. Tried different units such as Possible follow up in the future:
|
No the timeframe of this diagram is currently not configurable |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Show the beginning and end elapsed time under the HearbeatBar. Time should be timezone corrected. On the right, an tolerance of monitor.interval * 2 is considered as "now".
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)