-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: added kafka producer #3268
✨ feat: added kafka producer #3268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only noticed that this is still a draft after reviewing this, sorry
In general, this monitor is well written, but also include screenshots of it working and how you tested this monitor. (are there things you did not test?)
Does this deal with #139 (comment) ? Is this a common problem with kafka or does this not need to be adressed? CC: @cruscio
Thanks for your review, but this one is not self-tested completely But in Kafka (specially in K8s) when using Bootstrap Server instead of broker addresses your producers will get messed up when a node goes down, I don't know if this problem if coming from clients or no, but we want to make sure that producers are safe. |
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
b74258e
to
1030117
Compare
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
(I still would prefer to see |
* Add nostr DM notification provider * require crypto for node 18 compatibility * remove whitespace Co-authored-by: Frank Elsinga <frank@elsinga.de> * move closer to where it is used * simplify success or failure logic * don't clobber the non-alert msg * Update server/notification-providers/nostr.js Co-authored-by: Frank Elsinga <frank@elsinga.de> * polyfills required for node <= 18 * resolve linter warnings * missing comma --------- Co-authored-by: Frank Elsinga <frank@elsinga.de>
…ucer # Conflicts: # server/database.js # server/model/monitor.js # server/server.js
Yes that's correct in kafka we are adding new multiple brokers to have high availability, Also you can test that with one broker hostname that resolves to multiple brokers (In K8s Setup we have something called bootstrap server that acts like that) but when a node goes down our applications some times fail (Clients are bad or bootstrap server is returning bad addresses) |
But I don't know how KafkaJS handles load balancing and health checking, I found nothing in their docs |
Tick the checkbox if you understand [x]:
Description
Being able to monitor kafka instances by producing a message to them
I'm using producer since when kafka goes down or nodes became unavailable the producers are the first and most affected parts of ecosystem
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)