Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip trailing slashes to avoid 404 from Home Assistant's API endpoint #3283

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

lassebm
Copy link
Contributor

@lassebm lassebm commented Jun 18, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Strip trailing slashes to avoid 404 from Home Assistant's API endpoint.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@lassebm lassebm force-pushed the ha-strip-trailing-slashes branch from 5a351df to a00561f Compare June 18, 2023 16:28
@louislam louislam added this to the 1.23.0 milestone Jun 24, 2023
@louislam louislam changed the base branch from master to 1.23.X June 24, 2023 13:10
@louislam louislam merged commit bdcbd63 into louislam:1.23.X Jun 24, 2023
@lassebm lassebm deleted the ha-strip-trailing-slashes branch June 24, 2023 14:00
@ThomDietrich
Copy link

Hey @lassebm,
just out of interest. How did you define your Home Assistant check? Mine is configured this way and no fix via a PR was needed. Do you have a better check I might want to adapt?

image

@lassebm
Copy link
Contributor Author

lassebm commented Aug 18, 2023

@ThomDietrich If you had a trailing slash in the URL before the PR, HA would 404 due to double slashes in the constructed URL.

@ThomDietrich
Copy link

ah ^^ okay that makes sense. Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants