-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Extracted the dns monitor to its own monitor-type #3413
Conversation
# Conflicts: # server/model/monitor.js # server/uptime-kuma-server.js
I can test more of the monitors' functionality if requested, but given that this is just a code-move, I don't feel that this would be able to uncover any further bugs. (I have not touched the code at all, just where it lives) Secondary reason: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Slight side note, that massive if else block looks like the perfect candidate for a switch block
I limited the refactoring to lifting the code to another place |
# Conflicts: # server/model/monitor.js
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
This PR lifts the DNS-monitor from the gigantic
monitor.js
into its own monitor-typeType of change
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.