Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent race condition in showing toast message #3443

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Showing an up/down toast message depends on getting the monitor name from monitorList. Here is the race condition:

  1. Initial page load
  2. server sends a very long monitorList
  3. server sends a up/down heartbeat
  4. client tries to show toast, but monitorList has not finished loading.
Uncaught (in promise) TypeError: this.monitorList[data.monitorID] is undefined
    initSocketIO socket.js:189
    emit index.mjs:136
    emitEvent socket.js:498

Prevent toasts from showing if monitor name cannot be obtained is a clean solution, but I'm not sure if it's optimal.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

@chakflying chakflying force-pushed the fix/toast-race-condition branch from 6888491 to d4734ec Compare July 18, 2023 05:21
@louislam louislam added this to the 1.23.0 milestone Jul 31, 2023
@louislam louislam merged commit cda77c1 into louislam:master Aug 2, 2023
@chakflying chakflying deleted the fix/toast-race-condition branch August 16, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants