Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass cache bust param #3525

Merged
merged 16 commits into from
Aug 24, 2024

Conversation

dansullivan86
Copy link
Contributor

@dansullivan86 dansullivan86 commented Aug 4, 2023

  • I have read and understand the pull request rules.

Description

Fixes #575

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

server/model/monitor.js Outdated Show resolved Hide resolved
src/lang/en.json Outdated Show resolved Hide resolved
server/model/monitor.js Show resolved Hide resolved
src/lang/en.json Outdated Show resolved Hide resolved
server/model/monitor.js Outdated Show resolved Hide resolved
server/model/monitor.js Show resolved Hide resolved
@louislam louislam added this to the 2.0.0 milestone Aug 7, 2023
server/database.js Outdated Show resolved Hide resolved
@louislam louislam added the question Further information is requested label Sep 9, 2023
@louislam louislam modified the milestones: 2.0.0, 2.1.0 Oct 16, 2023
@CommanderStorm CommanderStorm added the area:monitor Everything related to monitors label Dec 8, 2023
@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label May 19, 2024
@CommanderStorm CommanderStorm modified the milestones: 2.1.0, 2.0.0 May 23, 2024
@CommanderStorm CommanderStorm added pr:please address review comments this PR needs a bit more work to be mergable pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:needs review this PR needs a review by maintainers or other community members labels May 23, 2024
@github-actions github-actions bot removed the pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again label May 23, 2024
CommanderStorm

This comment was marked as resolved.

@CommanderStorm CommanderStorm modified the milestones: 2.1.0, 2.0.0 Aug 24, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit dc3ad88 into louislam:master Aug 24, 2024
18 checks passed
@Root-FTW
Copy link

I don't see the option, how can I activate it?

image

@CommanderStorm
Copy link
Collaborator

What version are you running? (Are you running the beta)
This is a V2 only feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors pr:please address review comments this PR needs a bit more work to be mergable question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to pass a cachebusting parameter
6 participants