-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upload check label when monitor empty #3661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a reasonable change.
flashduty support uptime kuma plugin, so rename;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that while it is less likely that the change would cause a merge conflict with weblate, please still add your translation changes in weblate (once this is in master ^^) to avoid conflicts
I would like to re-confirm that, is it not a breaking change? |
not some big change, just adjust params to send. |
Thanks for the enhancement! All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval |
Tick the checkbox if you understand [x]:
Description
As the title described, this PR adds
check
label in flashduty which is a important one to display and distinguish.Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.