Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overall Status and Uptime to DashboardHome #437

Closed
wants to merge 1 commit into from

Conversation

lucasra1
Copy link

  • expand sended stats with sendAverageUptime(duration)
  • Display 24h, 7d, 30d, 90d average uptime of all monitors
  • Change Uptime.vue component to support displaying average uptime of all monitors

Issue #312

- expand sended stats with sendAverageUptime(duration)
- Display 24h, 7d, 30d, 90d average uptime of all monitors
- Change Uptime.vue component to support displaying average uptime of all monitors

Issue louislam#312
@louislam
Copy link
Owner

Thanks, I was not implemented this because I am worry about the performance. Especially for 90d, the sql sum up a lot of data.

So I think the performance proof should be required for this pr.

@gaby
Copy link
Contributor

gaby commented Sep 19, 2021

This PR will affect the performance of our uptime-kuma instance. We currently run the service with 2vCPU/2GB RAM, and we monitor close to 300 services/sites/servers.

@louislam louislam added the question Further information is requested label Sep 29, 2021
@salitcao
Copy link

salitcao commented Oct 6, 2021

I want to display average uptime 90 days. So how can I do that ?

@deefdragon
Copy link
Contributor

A note on the performance/implementation: it might be possible to use a sliding summation/data collection for the graphs. In that case, you only need to add/remove the values that are now/are no longer relevant. The first request will be slow as the data is collected, but after that, it will be much faster.

@louislam
Copy link
Owner

Thanks, I was not implemented this because I am worry about the performance. Especially for 90d, the sql sum up a lot of data.

So I think the performance proof should be required for this pr.

Closed due to this reason and seems staled.

@louislam louislam closed this Apr 14, 2022
@gaby
Copy link
Contributor

gaby commented Apr 14, 2022

@louislam what about modifying this PR to only do 24hr, 3 day, 7 day. Having the 30-90 day option are excessive.

Other option would be to make this Optional in the UI.

@louislam
Copy link
Owner

@louislam what about modifying this PR to only do 24hr, 3 day, 7 day. Having the 30-90 day option are excessive.

Other option would be to make this Optional in the UI.

I think the performance is still questionable, this feature should be implemented after the uptime calculation performance improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants