Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [JSON-Query] Prevent parsing string-only JSON #4425

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Fix: [JSON-Query] Prevent parsing string-only JSON #4425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
854ac38
Fix: Prevent parsing string-only JSON
chakflying Jan 26, 2024
21e1be2
Chore: Add try-catch to be safe
chakflying Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions server/model/monitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,8 +578,12 @@ class Monitor extends BeanModel {
let data = res.data;

// convert data to object
if (typeof data === "string") {
data = JSON.parse(data);
if (typeof data === "string" && res.headers["content-type"] !== "application/json") {
chakflying marked this conversation as resolved.
Show resolved Hide resolved
louislam marked this conversation as resolved.
Show resolved Hide resolved
try {
data = JSON.parse(data);
} catch (_) {
// Failed to parse as JSON, just process it as a string
}
}

let expression = jsonata(this.jsonPath);
Expand Down