Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PublicGroupList.vue #4444

Closed
wants to merge 1 commit into from
Closed

Conversation

mobeicanyue
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Thanks for your hard work!
This PR fixes #4365.
Adjusted column values in PublicGroupList to extend status bars in small screens, origin from #4736.
I suggested my style,
But that friend dont reply me, and I think it will lag the progress.
So I pull a new requests, hoping to be merge.
Thanks !

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to not work as expected)
  • Other
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

image

image

@CommanderStorm
Copy link
Collaborator

But that friend dont reply me, and I think it will lag the progress

Your suggestion was made 4 days ago.
I think it is a bit unreasonable to expect this fast responses or expect a PR to be merged this quickly.

I am going to close this PR as a duplicate, because I don't see the additional value.
The comments in #4376 can be merged by maintainers into said PR, but we (the maintainers of uptime kuma) have not been able to review either PR or the comments yet.

Just that we are clear in communication:
Closing this PR does not mean that the suggestion is bad or that it won't get merged, but rather that I'd like to keep the discussion focused a bit more ^^

@mobeicanyue
Copy link
Contributor Author

Ok, thanks for reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could we extend the length of status bar?
2 participants