Fix: handle monitor names with slashes

[andipaetzold]

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

• I have read and understand the pull request rules.

Description

On the details view, the group text above the monitor name is generated by checking for slashes in monitor.pathName. This causes issues when the monitor name contains a slash. E.g. for the name GitHub (/louislam) the group GitHub ( is detected.

What changed:

• a new property path on Monitor that stores the path as an array
• pathName is derived from path to not double the db requests

Type of change

Please delete any options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• User interface (UI)

Checklist

• My code follows the style guidelines of this project
• I ran ESLint and other linters for modified files
• I have performed a self-review of my own code and tested it
• I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
• My changes generates no new warnings
• My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Description	Before	After
No group, no slash
No group, one slash
No group, two slashes
Group, no slash
Group, one slash
Group, two slashes

[CommanderStorm]

Foremost, good catch! That is something that we did not think about.
I think !this.monitor.pathName.includes("/") => group = "" is a sort of funny bug 😅

Overall, this looks good to me (I have left some syle-comments, but those may be ignored if you don't think they are valid)
Thanks for including all the screenshots in the description, they help a lot.

I am not quite thrilled about adding another field to the MonitorJSON, but after looking at the usage of pathName, I agree that this is the better choice ^^

[andipaetzold]

I updated the jsdoc and would not apply the other change as explained in the thread.

I am not quite thrilled about adding another field to the MonitorJSON, but after looking at the usage of pathName, I agree that this is the better choice ^^

We could remove pathName from the monitor model and use monitor.path.join(' / ') instead - but that would only spread complexity around the code-base.

[CommanderStorm]

but that would only spread complexity around the code-base

MonitorJSON is exported to notifications and may thus be used in templates
⇒ inlining would be a breaking change

I don't really see a benefit from doing so
⇒ I'd vote for keeping it as is