-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New notification provider: CallMeBot API #4605
Merged
CommanderStorm
merged 7 commits into
louislam:master
from
BothimTV:add-callmebot-support
Apr 2, 2024
Merged
New notification provider: CallMeBot API #4605
CommanderStorm
merged 7 commits into
louislam:master
from
BothimTV:add-callmebot-support
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BothimTV
changed the title
Added support for the CallMeBot API (WhatsApp, Telegram Call and Facebook Messanger)
New Notification provider: CallMeBot API
Mar 20, 2024
BothimTV
changed the title
New Notification provider: CallMeBot API
New notification provider: CallMeBot API
Mar 20, 2024
Co-authored-by: Frank Elsinga <frank@elsinga.de>
…t better readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks pretty god to me.
I have left two inline comments
Closed
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Thanks for the new notification provder! All changes in this PR are small and uncontroversial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
This adds the support for CallMeBot.com in order to have WhatsApp notifications.
This additionally allows you to use it for Signal, Telegram Message + Call and Facebook Messanger. I didn't explicitly added the support for Signal and Telegram (as Message) because this was already implemented. But this still works as this is just a simple GET request to the user generated endpoint.
Type of change
Checklist
Screenshots (if any)
UP
DOWN