Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New notification provider: CallMeBot API #4605

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

BothimTV
Copy link
Contributor

@BothimTV BothimTV commented Mar 20, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This adds the support for CallMeBot.com in order to have WhatsApp notifications.
This additionally allows you to use it for Signal, Telegram Message + Call and Facebook Messanger. I didn't explicitly added the support for Signal and Telegram (as Message) because this was already implemented. But this still works as this is just a simple GET request to the user generated endpoint.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

Event Before After
UP - image
DOWN - image
Certificate-expiry - image
Testing - image

@BothimTV BothimTV changed the title Added support for the CallMeBot API (WhatsApp, Telegram Call and Facebook Messanger) New Notification provider: CallMeBot API Mar 20, 2024
@BothimTV BothimTV changed the title New Notification provider: CallMeBot API New notification provider: CallMeBot API Mar 20, 2024
CommanderStorm

This comment was marked as resolved.

BothimTV and others added 2 commits March 21, 2024 14:23
@chakflying chakflying added the area:notifications Everything related to notifications label Mar 29, 2024
@CommanderStorm CommanderStorm added the question Further information is requested label Apr 2, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks pretty god to me.
I have left two inline comments

server/notification-providers/call-me-bot.js Outdated Show resolved Hide resolved
src/components/notifications/CallMeBot.vue Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm marked this pull request as ready for review April 2, 2024 18:36
BothimTV and others added 2 commits April 2, 2024 20:41
@CommanderStorm
Copy link
Collaborator

Thanks for the new notification provder!

All changes in this PR are small and uncontroversial
⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 937c8a9 into louislam:master Apr 2, 2024
17 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants