Update CONTRIBUTING.md for how to set up a Docker builder #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -490,3 +490,30 @@ We have a few procedures we follow. These are documented here: | |||
|
|
|||
| </p> | |||
| </details> | |||
|
|
|||
| ### Set up a Docker Builder | |||
There was a problem hiding this comment.
Can we wrap this in a <details> block as the other ones above or move this to the Release part of the contribution guide? (making who we are adressing in this clearer)
|
|
||
| ### Set up a Docker Builder | ||
|
|
||
| - amd64, armv7 using local. |
There was a problem hiding this comment.
Bit unclear what is being documented here. what are these bullet points?
An introductory sentence why one would need/want to set up a docker builder might be helpfull for other devs that did not read this PR.
There was a problem hiding this comment.
It is a Docker config that is for me to build the multi arch images. Probably for myself only, can be improved if anyone else need this later.
CommanderStorm
added
the
area:documentation
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I was using buildkit (qemu) to build arm64/armv7 docker image.
However, for some reason, it is no longer working for arm64. It is extremely slow and
npm ci --omit=devalways failed withnpm ERR! errno ECONNRESETerror. Tested on different PCs and different networks. Maybe ourpackage-lock.jsonis getting big now.To overcome the issue, now I set up a special Docker builder which will pass the arm64 build job to my real arm64 machine.