-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixed a typo for internal, unused part of the file upload icon for status page #4750
chore: fixed a typo for internal, unused part of the file upload icon for status page #4750
Conversation
I consider this as an uncontroversial bugfix Could you rebase this to said branch via running
|
config.icon
That's a lot of changes?? |
I think somebody changed the target to 1.23.x; it was originally based on the main branch. |
Needs to be rebased. Frank asked me to do that, but I've been too busy with my job |
For context: my original PR was 1 commit, +/- 1 line |
I guess then this is going into Think this can also be considered a "feature" as this strictly speaking adds functionality to the internal api and not to the user interface. => merging with junior maintainer approval. |
@CommanderStorm I made a backport to 1.23.X here: #4757 |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #4749
Type of change
Please delete any options that are not relevant.
Checklist