Removed now unnecessary version checking #4815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
commented
Jun 3, 2024
| @@ -19,7 +19,7 @@ const nodeVersion = process.versions.node; | |||
|
|
|||
| // Get the required Node.js version from package.json | |||
| const requiredNodeVersions = require("../package.json").engines.node; | |||
| const bannedNodeVersions = " < 14 || 20.0.* || 20.1.* || 20.2.* || 20.3.* "; | |||
| const bannedNodeVersions = " < 18 || 20.0.* || 20.1.* || 20.2.* || 20.3.* "; | |||
There was a problem hiding this comment.
attached to the v2.0 milestone due to this bugfix ^^
CommanderStorm
commented
Jun 3, 2024
CommanderStorm
added
pr:needs review
|
(I know, merging my own PR is bad. This one is just tests/docs => can't see how this can cause problems) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
In #4806 I noticed that the removal of node <18 was not as complete as it could have been.
This PR removes a few additional instances
Type of change
Please delete any options that are not relevant.
Checklist