Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed some monitor drift in terms of code comments #4820

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

CommanderStorm
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

During #4806 I noticed that there has been some dirift in how we document MonitoringTypes.
This PR removes the drift

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@CommanderStorm CommanderStorm added area:monitor Everything related to monitors house keeping pr:needs review this PR needs a review by maintainers or other community members labels Jun 4, 2024
@CommanderStorm CommanderStorm changed the title removed some monitor drift in terms of imports and documentation removed some monitor drift in terms of code comments Jun 7, 2024
@CommanderStorm
Copy link
Collaborator Author

Have removed the import changes.
Given that this is now only code comments which are changed, I am going to merge this without a review

@CommanderStorm CommanderStorm merged commit bc25b71 into master Jun 7, 2024
18 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Jun 7, 2024
@CommanderStorm CommanderStorm removed the pr:needs review this PR needs a review by maintainers or other community members label Jun 7, 2024
@CommanderStorm CommanderStorm deleted the unified-moniotrs branch October 4, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors house keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant