-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved zoho-cliq message format #4848
Conversation
- show PORT (cloned switchcase from discord,squadcast,servenio) - show monitorName in the first row to get on point also from messagge preview notification - avoid duplication of monitorName and monitorName in the message content
Notification providers are really hard to review.could you please fill out the part which I added to the PR description to make reviewing simpler? |
Updated the OP, btw the code is just taken as template from other monitor to avoid introducing breaking things 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. Looks better 👍
I have left a few questions/suggestions below. Could you have a look at how these look in Zoho?
Longer term (in case you are interested in improving this further, not a requirement for the PR) we could also look at https://www.zoho.com/cliq/help/restapi/v2/#Message_Cards_Poll
Seems like this can be made more useful
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Thanks for the change to the notification provider! 🎉 Note This PR is part of the All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.
UP
DOWN