Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved zoho-cliq message format #4848

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

FrancYescO
Copy link
Contributor

@FrancYescO FrancYescO commented Jun 12, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

  • show PORT (cloned switchcase from discord,squadcast,servenio)
  • show monitorName in the first row to get on point also from messagge preview notification
  • avoid duplication of monitorName and monitorName in the message content

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Event Before After
UP image image
DOWN image image
Certificate-expiry paste-image-here paste-image-here
Testing image image

- show PORT (cloned switchcase from discord,squadcast,servenio)
- show monitorName in the first row to get on point also from messagge preview notification
- avoid duplication of monitorName and monitorName in the message content
@CommanderStorm
Copy link
Collaborator

Notification providers are really hard to review.could you please fill out the part which I added to the PR description to make reviewing simpler?

@CommanderStorm CommanderStorm added area:notifications Everything related to notifications type:enhance-existing feature wants to enhance existing monitor pr:please address review comments this PR needs a bit more work to be mergable labels Jun 12, 2024
@FrancYescO
Copy link
Contributor Author

Updated the OP, btw the code is just taken as template from other monitor to avoid introducing breaking things 😅

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Looks better 👍

I have left a few questions/suggestions below. Could you have a look at how these look in Zoho?

Longer term (in case you are interested in improving this further, not a requirement for the PR) we could also look at https://www.zoho.com/cliq/help/restapi/v2/#Message_Cards_Poll
Seems like this can be made more useful

server/notification-providers/zoho-cliq.js Show resolved Hide resolved
server/notification-providers/zoho-cliq.js Outdated Show resolved Hide resolved
server/notification-providers/zoho-cliq.js Show resolved Hide resolved
server/notification-providers/zoho-cliq.js Outdated Show resolved Hide resolved
Co-authored-by: Frank Elsinga <frank@elsinga.de>
@CommanderStorm
Copy link
Collaborator

Thanks for the change to the notification provider! 🎉
(I have removed the code-duplication discussed in #4848 (comment))

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit fbf7b77 into louislam:master Jun 13, 2024
18 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants