Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined in log while creating a new monitor #5053

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

prabhsharan36
Copy link
Contributor

@prabhsharan36 prabhsharan36 commented Aug 26, 2024

⚠️ Please verify that this question has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

📝 Describe your problem
Hi,
While I was setting up the monitors, I saw undefined was written in info log. I checked the monitor object and found there's no id in that object which we are using while logging the info log resulting in undefined.

📝 Error Message(s) or Log
[MONITOR] INFO: Added Monitor: undefined User ID: 1

🐻 Uptime-Kuma Version
1.23.13

💻 Operating System and Arch
N/A

🌐 Browser
N/A

🖥️ Deployment Environment
x

✔️ Solution
Logging monitor.name instead of monitor.id

Screenshots
Screenshot from 2024-08-26 16-59-59
Screenshot from 2024-08-26 16-59-25

@CommanderStorm
Copy link
Collaborator

PRs welcome.
This sould be replaced by bean.id though, not the monitor.name.

@CommanderStorm CommanderStorm added area:monitor Everything related to monitors area:deployment related to how uptime kuma can be deployed pr:please address review comments this PR needs a bit more work to be mergable labels Aug 27, 2024
@CommanderStorm CommanderStorm merged commit 562de6a into louislam:master Aug 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:deployment related to how uptime kuma can be deployed area:monitor Everything related to monitors pr:please address review comments this PR needs a bit more work to be mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants