Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Notification Provider SIGNL4 #5058

Merged
merged 10 commits into from
Aug 28, 2024
Merged

New Notification Provider SIGNL4 #5058

merged 10 commits into from
Aug 28, 2024

Conversation

rons4
Copy link
Contributor

@rons4 rons4 commented Aug 27, 2024

New notification provider SIGNL4 added.

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This PR adds SIGNL4 as a notification channel for Uptime Kuma.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings

Screenshots (if any)

Event Before After
UP - monitor-down-alert-triggered
UP - monitor-down-alert-triggered
DOWN - monitor-up-alert-closed
Certificate-expiry - certificate-after-2
Testing - test-after

CommanderStorm

This comment was marked as resolved.

@CommanderStorm CommanderStorm added pr:please address review comments this PR needs a bit more work to be mergable area:notifications Everything related to notifications type:new proposing to add a new monitor labels Aug 27, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new notification provider! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 716832b into louislam:master Aug 28, 2024
10 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Aug 28, 2024
@rons4
Copy link
Contributor Author

rons4 commented Aug 29, 2024

Thank you @CommanderStorm .

The integration page is ready on our side:
https://docs.signl4.com/integrations/uptime-kuma/uptime-kuma.html

I just saw a small spelling mistake in this URL in SIGNL4.vue (uptime-kuima -> uptime-kuma) Shall I open a new PR?

Sorry for this.

We are going to post about the new integration in the next coming days.

@CommanderStorm
Copy link
Collaborator

no need for a PR.
Have adjusted the URL in 032ac16

Thanks for the heads up. ^^

On that blog post, please make sure to include a warning that this notification provider is currently waiting for the v2.0 release on the uptime-kuma-side.
Feel free to link to #4500 which users can subscribe to.

I won't be able to get v2.0 ready in the next month (reason: I am on vacation 31.8. - 22.9. and could not get this done beforehand)

PS: The UI looks quite nice from the screenshots. *Tips hat to the UI designer(s) on your team ^^

@rons4
Copy link
Contributor Author

rons4 commented Aug 29, 2024

Perfect. Thanks a lot. I have updated the documentation page including the link:
image

Thanks also for the UI praise. I will pass it to the team ;-)

Have a great and relaxing vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable type:new proposing to add a new monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants