Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable certificate expiry notification when SSL errors are ignored #5156

Conversation

Suven-p
Copy link
Contributor

@Suven-p Suven-p commented Oct 4, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #4029

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have note a question/request about "monitor.ignoreTls"(newVal) which seems a bit confusing to me.
Otherwise looks excellent 👌

src/pages/EditMonitor.vue Show resolved Hide resolved
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks enhancement to the frontend! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 1cf88f4 into louislam:master Oct 4, 2024
17 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Oct 4, 2024
@CommanderStorm CommanderStorm added area:monitor Everything related to monitors area:dashboard The main dashboard page where monitors' status are shown labels Oct 4, 2024
@Suven-p Suven-p deleted the 4029-Disable_Certificate_Expiry_Notifications branch October 6, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown area:monitor Everything related to monitors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificate Expiry Notification should be disabled if Ignore TLS/SSL error for HTTPS websites is on
2 participants