-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support sound and title in TechulusPush
#5178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good.
I have made some comments about the UI part.
For testing notification porovider we require at least one screenshot of the notification provider working, could you please update the part of the description which I edited? 😉
TechulusPush
to support sound and title
TechulusPush
to support sound and titleTechulusPush
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things left.
Please adresss #5178 (comment) though.
Given that you have started the PR from master
, I cannot do this myself or apply suggestions..
let data = { | ||
"title": notification?.pushTitle?.length ? notification.pushTitle : "Uptime-Kuma", | ||
"body": msg, | ||
"timeSensitive": notification.pushTimeSensitive ?? false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"timeSensitive": notification.pushTimeSensitive ?? false, | |
"timeSensitive": notification.pushTimeSensitive ?? true, |
sure, I'll fix all of these today |
@CommanderStorm I've addressed your review comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adjustment to the notification provider! ❤️
Note
This PR is part of the v2.0
merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^
All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Update Push by Techulus integration to include more features, I'm the founder and creator of Push by Techulus.
https://github.com/techulus
Type of change
Checklist
Screenshots