Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sound and title in TechulusPush #5178

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

arjunkomath
Copy link
Contributor

@arjunkomath arjunkomath commented Oct 9, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Update Push by Techulus integration to include more features, I'm the founder and creator of Push by Techulus.
https://github.com/techulus

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

Event Before After
UI - CleanShot 2024-10-09 at 23 54 35@2x
Pressing the Testing Button in the app CleanShot 2024-10-09 IMG_6B137624A276-1

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good.
I have made some comments about the UI part.

For testing notification porovider we require at least one screenshot of the notification provider working, could you please update the part of the description which I edited? 😉

src/components/notifications/TechulusPush.vue Outdated Show resolved Hide resolved
src/components/notifications/TechulusPush.vue Show resolved Hide resolved
server/notification-providers/techulus-push.js Outdated Show resolved Hide resolved
src/components/notifications/TechulusPush.vue Show resolved Hide resolved
@CommanderStorm CommanderStorm changed the title Update Push by Techulus integration to support new features feat: update Techulus integration to support sound and title Oct 9, 2024
@CommanderStorm CommanderStorm changed the title feat: update Techulus integration to support sound and title feat: update TechulusPush to support sound and title Oct 9, 2024
@CommanderStorm CommanderStorm changed the title feat: update TechulusPush to support sound and title feat: support sound and title in TechulusPush Oct 9, 2024
@CommanderStorm CommanderStorm added area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable labels Oct 9, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things left.

Please adresss #5178 (comment) though.
Given that you have started the PR from master, I cannot do this myself or apply suggestions..

let data = {
"title": notification?.pushTitle?.length ? notification.pushTitle : "Uptime-Kuma",
"body": msg,
"timeSensitive": notification.pushTimeSensitive ?? false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"timeSensitive": notification.pushTimeSensitive ?? false,
"timeSensitive": notification.pushTimeSensitive ?? true,

src/components/notifications/TechulusPush.vue Outdated Show resolved Hide resolved
src/components/notifications/TechulusPush.vue Outdated Show resolved Hide resolved
src/components/notifications/TechulusPush.vue Outdated Show resolved Hide resolved
src/components/notifications/TechulusPush.vue Outdated Show resolved Hide resolved
@arjunkomath
Copy link
Contributor Author

A few things left.

Please adresss #5178 (comment) though. Given that you have started the PR from master, I cannot do this myself or apply suggestions..

sure, I'll fix all of these today

@arjunkomath
Copy link
Contributor Author

@CommanderStorm I've addressed your review comments

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjustment to the notification provider! ❤️

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit bafca6b into louislam:master Oct 10, 2024
18 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants