Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Improve Certificate Info Display #519

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Oct 1, 2021

In response to #514, improve the certificate info display such that the full chain is shown. Hopefully can help with debugging similar situations in the future.

Unfortunately the Certificate Icon is a premium icon in Font Awesome.

light dark
image image

@chakflying chakflying changed the title Feat: Improve Certificaet Info Display Feat: Improve Certificate Info Display Oct 1, 2021
@Neer171
Copy link

Neer171 commented Oct 1, 2021

@chakflying here is font awesone SSL icon

<i class="fab fa-expeditedssl"></i>

https://fontawesome.com/v5.15/icons/expeditedssl?style=brands

either we can use lock icon for SSL

https://fontawesome.com/v5.15/icons?d=gallery&p=2&q=lock

@louislam
Copy link
Owner

louislam commented Oct 1, 2021

Am I doing it right?😂

https://jsfiddle.net/or5yp30L/10/

image

@chakflying
Copy link
Collaborator Author

Damn that totally works! Icon updated.

@louislam louislam added this to the 1.8.0 milestone Oct 4, 2021
@Neer171
Copy link

Neer171 commented Oct 4, 2021

Little editing
https://jsfiddle.net/NomadNick/7u8seLgy/1/

@chakflying
Copy link
Collaborator Author

Appreciate the effort, but I think the current one is fine.

@louislam louislam merged commit 865b721 into louislam:master Oct 5, 2021
@louislam
Copy link
Owner

louislam commented Oct 9, 2021

Fixed a bug related to this pr: cac0a46

If the cert is still the old format, it throws error.

Might have to ensure .certInfo in the object, or clearing the old json?

@chakflying
Copy link
Collaborator Author

Thanks! Is it okay now, or do you want me to add a db patch with DELETE FROM monitor_tls_info?

@louislam
Copy link
Owner

louislam commented Oct 9, 2021

Thanks! Is it okay now, or do you want me to add a db patch with DELETE FROM monitor_tls_info?

I think it is safe, don't need to patch. I did a global search of $root.tlsInfoList, no other calls outside the computed function tlsInfo()

@chakflying chakflying deleted the improve-certInfo branch October 23, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants