Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slug input #5239

Merged
merged 5 commits into from
Nov 26, 2024
Merged

fix: slug input #5239

merged 5 commits into from
Nov 26, 2024

Conversation

Zoobdude
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

When specifying a URL slug with UPPERCASE characters in it, it is automatically converted to lowercase by the backend, however, the browser redirects you to the uppercase version causing this 'no slug?' error.

Media1.mp4

It seems to also be shown in #1814 (though part of that issue is todo with it being hosted on Replit).

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@louislam louislam added this to the 2.0.0 milestone Oct 24, 2024
@louislam
Copy link
Owner

Good catch. Make me wondering if the slug should be case sensitive or insensitive.

@louislam louislam modified the milestones: 2.0.0, 2.1.0 Nov 7, 2024
@Zoobdude Zoobdude marked this pull request as ready for review November 11, 2024 14:06
@Zoobdude
Copy link
Contributor Author

Zoobdude commented Nov 11, 2024

Sorry this took far too long @louislam. I agree that making a the slug not case sensitive is probably logical, so I've implemented that.

@louislam louislam modified the milestones: 2.1.0, 2.0.0-beta.1 Nov 11, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable change and works as advertised ❤️

@CommanderStorm CommanderStorm merged commit cdb8ad3 into louislam:master Nov 26, 2024
19 checks passed
@Zoobdude Zoobdude deleted the fix-slug-input branch November 26, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants