Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Knex cannot set a default value for TEXT field (MariaDB) #5261

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

louislam
Copy link
Owner

@louislam louislam commented Oct 27, 2024

Description

Read more: #5048 (comment)
knex/knex#2649

As this issue was reported in 2018, I don't think it will fixed in soon, so we have to do it in Uptime Kuma.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@louislam louislam marked this pull request as draft October 27, 2024 16:44
@louislam louislam added this to the 2.0.0 milestone Oct 27, 2024
@louislam louislam marked this pull request as ready for review October 28, 2024 05:04
@louislam louislam merged commit ca09429 into master Oct 28, 2024
19 checks passed
@louislam louislam mentioned this pull request Oct 29, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant