-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SQL query empty result monitoring #5429
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR.
Unfortunately, I think accepting this PR would make future work like migrating mssql towards the inital work laid out here a lot more difficult
I think a better way would be to migrate the individual monitor you need to this form.
=> would you be open to migrating the monitor you need to this alternative instead?
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Hello @louislam and everyone!
This little PR tries to introduce new features for handling the results of SQL monitoring queries. Specifically, it ensures that an empty result can return an error, while other outcomes will not. The implementation is designed to avoid breaking changes with the current version.
Specifically, the implementation ensures:
Changes Implemented
EditMonitor.vue
to enable error checking functionality.and Italian (my native language).What's Missing
Additional Notes
This is my first pull request in an open-source project, so please let me know if I’ve made any mistakes or if improvements can be made.
Thanks
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)