Harden 2FA/TOTP implementation according to rfc6238 (part 1) #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate TOTP secret using WebCrypto API (see louislam#640)
deefdragon
suggested changes
Oct 10, 2021
|
Do not pass the unit test, it seems that the crypto api is not available in the Node.js |
|
It is but only as of NodeJS 15. https://nodejs.org/docs/latest/api/webcrypto.html#webcrypto_crypto_getrandomvalues_typedarray |
louislam
reviewed
Oct 13, 2021
# Conflicts: # src/util.js
…_patch-1 # Conflicts: # src/util.js
|
Tested working, but forgot to put in the recent release... Postpone to the next release. |
You're welcome. Last puzzle piece for respecting rfc6238 is also PRed as of now (#743). Would be great if you could add this to the next release as well. It's a simple but important fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements issue 1 in #640