Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Lazy load language files #966

Merged
merged 4 commits into from
Nov 29, 2021
Merged

[wip] Lazy load language files #966

merged 4 commits into from
Nov 29, 2021

Conversation

louislam
Copy link
Owner

@louislam louislam commented Nov 26, 2021

Description

Load the language files on demand, rather than loaded all language files at startup.

No significant improvement. The page load speed should be faster theoretically, as the compiled index js file is smaller now.

Type of change

  • Core

Tasks

  • Load the language file at the first page load.
  • Settings' menu words are not reactive?

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and test it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

image

@louislam louislam merged commit bedc1f8 into master Nov 29, 2021
@CommanderStorm CommanderStorm deleted the lazy-load-lang branch December 14, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant