Add zoom-format #227
Open
Add zoom-format #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovasoa
requested changes
Jan 29, 2024
| @@ -116,6 +116,9 @@ pub struct Arguments { | |||
| /// retrying partially failed downloads, or stitching the tiles with an external program. | |||
| #[arg(short = 'c', long = "tile-cache")] | |||
| pub tile_storage_folder: Option<PathBuf>, | |||
| /// A zoom_level image format suffix eg.default.png or default.jpg | |||
| #[arg(short = 'f', long = "zoom-format", default_value = "auto")] | |||
There was a problem hiding this comment.
The type probably shouldn't be String if not all strings are valid. The documentation should explain precisely what this does.
| ) -> Result<Tile, TileDownloadError> { | ||
| if !"auto".eq(&self.zoom_format) { |
There was a problem hiding this comment.
This is probably not the right place to handle that. This option is specific to the iiif dezoomer, isn't it? If it is, then it should be handled in the dezoomer.
lovasoa
requested changes
Jan 29, 2024
| @@ -116,6 +116,9 @@ pub struct Arguments { | |||
| /// retrying partially failed downloads, or stitching the tiles with an external program. | |||
| #[arg(short = 'c', long = "tile-cache")] | |||
| pub tile_storage_folder: Option<PathBuf>, | |||
| /// A zoom_level image format suffix eg.default.png or default.jpg | |||
| #[arg(short = 'f', long = "zoom-format", default_value = "auto")] | |||
| pub zoom_format: String, | |||
There was a problem hiding this comment.
If the option is specific to IIIF, then its name should probably reference it.
Maybe something like --iiif-tile-format=jpg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zoom-format for #226