fix: preserve field position when renaming #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying jsonjoy-builder with
|
| Latest commit: |
39b42d7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5025a684.jsonjoy-builder.pages.dev |
| Branch Preview URL: | https://fix-field-rename-position.jsonjoy-builder.pages.dev |
lovasoa
force-pushed
the
fix/field-rename-position
branch
2 times, most recently
from
55421ee to
86e8aed
Compare
When editing a field's name, the field was being moved to the end of the properties list because the old property was deleted and re-added with the new name. Fixed by iterating through properties in order and replacing the old key with the new key while maintaining the original position. Also updated the required array to use the new field name. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
lovasoa
force-pushed
the
fix/field-rename-position
branch
from
86e8aed to
39b42d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where fields would move to the end of the properties list when their names were edited.
Root Cause
When renaming a field, the old property was being deleted and re-added with the new name, causing it to move to the end of the object.
Solution
renameObjectProperty()insrc/lib/schemaEditor.tshandleEditFieldin SchemaVisualEditor to use the new utilityChanges
renameObjectProperty()utility functionrenameObjectProperty()Test Coverage
renameObjectProperty()functionCloses #11