Skip to content

Add Drag and Drop Functionality #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ctsstc wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add Drag and Drop Functionality #28

ctsstc wants to merge 4 commits into from

Conversation

@ctsstc
Copy link
Contributor

@ctsstc ctsstc commented Jan 20, 2026 •
edited
Loading

Overview

This adds drop and drop functionality to help order items as well as move them into or out of nested items like objects or lists.

Preview

drag.and.drop.json.schema.editor.mov

Hurdles

  • There were two write operations happening at the same time which made it so that the inner child node would duplicate.
    • This required some consolidation to get them into a single operation.

Notes

  • This clears up lint issues, runs the formatter, and runs the fix script.
    • I'm planning to get into a separate PR and get those merged into main so it helps clear up some of the noise here.
    • I'll likely have to handle some conflicts afterwards.
    • Opened Fix Check Errors #29 hopefully that can get merged soon and I can rebase this branch to clean it up some.
  • 🔥 This is still a WIP. I need to do a walk-through giving it a once-over (probably tomorrow [Tuesday]), but it seems to be functioning fine now.
    • Any feedback would be great though.
  • I'm glad it's working how I wanted it to finally, but I do wonder if there might have been a library that could have made this much more simple. Also given how heavy this change is, it feels like maybe some of it should be extracted out potentially?
  • I think this change may open up copying (it was already happening as a bug for a moment 😆 )

Resolutions

ctsstc added 4 commits January 19, 2026 22:42
@ctsstc
Initial drag and drop
eb40383 
Still need to patch duplication that occurs when moving an item from a child to another location outside of its current container.
@ctsstc
Handle child to parent drag and drop, as well as visa versa
1d3d73a 
There were two write operations happening at the same time which made it so that the inner child node would duplicate. This had to do some consolidation to get them into a single operation.
@ctsstc
Run fix
63bc53a 
This really ought to have happened before I started, but here we are. Maybe I can run it off of main on its own branch, but it'll surely be conflict city. Hopefully not too bad.
@ctsstc
Fix missing imports
5eb511c 
Not sure why this isn't picked up by the check. Ah, the check script must not cover this or do type checking. But there is a typecheck script.
@ctsstc
Copy link
Contributor Author

ctsstc commented Jan 22, 2026

Some research has me thinking maybe I should have went the direction of utilizing a library like:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Allow re-ordering of fields

1 participant

@ctsstc