Include libspng as dependency #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brilliant, thank you. |
|
Perhaps randy408/libspng@db86b2c should also be backported? See: libvips/libvips#1778. |
|
I'm keen to release sharp v0.26.0 (plus the new statically-linked libvips 8.10.0). The switch to static linking should allow for more frequent releases of the prebuilt libvips binaries, plus we can bump these in patch version increments of sharp. |
|
Great! These patches are no longer needed when libspng v0.6.1 is released (which will soon be released, I think). |
|
Ah, I've just followed the trail of randy408/libspng#123 and given it's possible for libpng+libvips to create PNG images that libspng cannot then read back again, maybe we should backport this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with the Windows binaries. I've backported randy408/libspng@b21b214 to help libvips/libvips#1748.